[Intel-gfx] [PATCH 09/16] drm/i915/gmbus: Reset the controller on initialisation
chris at chris-wilson.co.uk
Fri May 13 17:53:43 CEST 2011
On Fri, 13 May 2011 08:01:51 -0700, Keith Packard <keithp at keithp.com> wrote:
> On Fri, 13 May 2011 10:32:25 +0100, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > It has been booting daily on several machines for a month. I agree it
> > wouldn't have worked, but the since we automatically fallback to GPIO
> > should it go south, the failures didn't stop the external monitors from
> > being lit up.
> Yeah, nice that we fall back. Do we want a warning in the kernel log
> when that happens (once, not multiple times)? At least some way to
> verify that the new code is doing what we expect it to do.
We give a warning when we fail a GMBUS sequence and switch (permanently)
to using GPIO. I've been desensitised to those warnings, because there is
sometimes, depending upon the hardware and probes, one channel which fails.
The fact that I'd so utterly broken the code didn't occur to me.
Chris Wilson, Intel Open Source Technology Centre
More information about the Intel-gfx