[Intel-gfx] [PATCH 1/2] drm/i915: add Ivybridge clock gating init function
jbarnes at virtuousgeek.org
Wed May 11 10:26:20 PDT 2011
On Wed, 11 May 2011 13:20:55 -0400
Adam Jackson <ajax at redhat.com> wrote:
> On Wed, 2011-05-11 at 09:52 -0700, Jesse Barnes wrote:
> > + /*
> > + * On Ibex Peak and Cougar Point, we need to disable clock
> > + * gating for the panel power sequencer or it will fail to
> > + * start up when no ports are active.
> > + */
> Nitpick: Probably either this comment (and its mate in
> gen6_init_clock_gating) should just refer to PCH generically if this is
> going to keep being true, or this instance of it should read Panther
> Point instead of ibx/cpt. Assuming wikipedia isn't lying to me about
> chipset names, anyway.
I hope it's not true for PPT (my current IVB system uses CPT), but it
gets split out in the next patch anyway...
Jesse Barnes, Intel Open Source Technology Center
More information about the Intel-gfx