[Intel-gfx] [PATCH v3 2/2] drivers: i915: Default max backlight brightness value
olof at lixom.net
Tue Nov 8 15:02:00 PST 2011
On Tue, Nov 8, 2011 at 2:47 PM, Matthew Garrett <mjg59 at srcf.ucam.org> wrote:
> On Tue, Nov 08, 2011 at 02:41:56PM -0800, Simon Que wrote:
>> There is a backup kernel partition that can be used for boot.
>> Failing that, the system can boot from a recovery image over USB.
> So absolutely no video code in the firmware at all? Ok. What I'd really
> rather see here is some generic way for platform-specific code to pass
> the correct value to the driver. You're already exposing various things
> via the chromeos-acpi code, can you use that to set things up sensibly?
> It's obviously possible to use the command line to transfer this
> information, it's just considered pretty poor style.
How about a DMI table check that overrides whatever is setup (or not
setup) from the video bios? We know exactly what platforms need this
so that table would be easy to specify.
I'm not sure how well this would fit into our platform layer code, it
would be pretty nasty to have to export the default backlight variable
from the i915 driver and modify it from there as well, and I'm sure
noone wants to see any kind of chromeos-specific code paths in the 915
driver (myself included).
More information about the Intel-gfx