[Intel-gfx] [PATCH 1/3] drm/i915: relative_constants_mode race fix

Ben Widawsky ben at bwidawsk.net
Wed Nov 23 22:59:17 CET 2011


On Wed, Nov 23, 2011 at 01:34:06PM -0800, Keith Packard wrote:
> On Sat, 22 Oct 2011 19:41:23 -0700, Ben Widawsky <ben at bwidawsk.net> wrote:
> 
> > +		    mode != dev_priv->relative_constants_mode) {
> > +			if (INTEL_INFO(dev)->gen < 4)
> > +				return -EINVAL;
> > +
> > +			if (INTEL_INFO(dev)->gen > 5 &&
> > +			    mode == I915_EXEC_CONSTANTS_REL_SURFACE)
> > +				return -EINVAL;
> 
> You need to clean up before returning; you've allocated cliprects and an
> exec buffer and also locked the mutex.

The hits just keep on coming for me it seems. I had this fixed locally
and I'm not even sure how I ended up propagating this patch. It all
broke when I rebased the original patch series to split this fix out.

Even more unfortunate is this repo with the changes has long since been
corrupted to destruction. So I shall fix this for the forced throttling
series, and you can take it from there if you like it.

Thanks for catching this. Shame on me...
Ben
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20111123/1608ef79/attachment.pgp>


More information about the Intel-gfx mailing list