[Intel-gfx] [PATCH 1/3] drm/i915: collect more per ring error info

Daniel Vetter daniel at ffwll.ch
Fri Oct 7 15:52:01 CEST 2011


On Tue, Oct 04, 2011 at 02:11:51PM -0700, Ben Widawsky wrote:
> V1: Just added per ring page faults
> Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> 
> V2: Added much more per ring stuff
> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>

While you wrestle this, can we cut down on the line-noise a bit by using
ring->mmio_base an per-ring functions? By storing VCS, BCS, RCS in
ring->id instead of the flags that are currently there this should reduce
quite a bit.
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48



More information about the Intel-gfx mailing list