[Intel-gfx] Sony VAIO VPC-SA2 blinking/waves on LVDS

[Олег Герман]

Is it complete solution or temporary workaround?
How can I help, to push this fix to upsteam?

2011/10/11 Олег Герман <oleg.german at gmail.com>:
> yep, i just commented-out this line in ubuntu kernel
> http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-oneiric.git;a=blob;f=drivers/gpu/drm/i915/intel_display.c;h=e917c7b853bc62f885ffb731049ac3ff03ef8a70;hb=HEAD#l5120
>
> and it works!
>
> 2011/10/11 Daniel Vetter <daniel at ffwll.ch>:
>> On Tue, Oct 11, 2011 at 01:50:34PM +0400, Олег Герман wrote:
>>> > I'd wager this is dithering gone wrong. Can you boot with drm.debug=0xe
>>> > and attach the full dmesg? Also please attach xrandr --verbose.
>>>
>>> also bug is not reproduced on external monitors
>>
>> Can you try the below patch, please?
>> -Daniel
>>
>> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>> index f0e5f9f..d145527 100644
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -5533,7 +5533,7 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc,
>>        pipeconf &= ~PIPECONF_DITHER_TYPE_MASK;
>>        if ((is_lvds && dev_priv->lvds_dither) || dither) {
>>                pipeconf |= PIPECONF_DITHER_EN;
>> -               pipeconf |= PIPECONF_DITHER_TYPE_ST1;
>> +               //pipeconf |= PIPECONF_DITHER_TYPE_ST1;
>>        }
>>        if (is_dp || intel_encoder_is_pch_edp(&has_edp_encoder->base)) {
>>                intel_dp_set_m_n(crtc, mode, adjusted_mode);
>>
>> --
>> Daniel Vetter
>> Mail: daniel at ffwll.ch
>> Mobile: +41 (0)79 365 57 48
>>
>