[Intel-gfx] [PATCH 2/3] drm/i915: Rename HDMI register field definitions

Paulo Zanoni przanoni at gmail.com
Mon Oct 17 21:04:29 CEST 2011

2011/10/14 Chris Wilson <chris at chris-wilson.co.uk>:
> I'm a little more dubious over the value of this patch. The extra
> information is nice, but the patch doesn't impact much upon the
> readibility of the code. It seems like this should have the potential to
> clarify quite a bit of the logic and make it more consistent, yet that
> is not addressed here. Do you have plans to make use of the cleanup?

Well, "readability" has a different definition for each different
reader. The patch was based on my own definition, but I'm open to
suggestions. If you think it's not worth, just drop it: no problem.

> Does it catch any bugs?

Not yet, but it would have helped catch the one from my previous patch...
Paulo Zanoni

More information about the Intel-gfx mailing list