[Intel-gfx] [PATCH 2/2] drm/i915: properly prefault for pread/pwrite

Keith Packard keithp at keithp.com
Sun Oct 23 21:23:47 CEST 2011


On Sun, 23 Oct 2011 12:18:30 +0200, Daniel Vetter <daniel at ffwll.ch> wrote:
> Hi Keith,
> 
> This patch isn't in your -next pull. This papers over a spurious -EFAULT
> in the pwrite/pread paths that actually gets hit in the wild. The real fix
> in the form of a almost complete rewrite of the pwrite/pread paths won't
> be ready for 3.2.

We had several comments wondering whether writing zeros was OK as this
occurs before some potential error returns that should leave the buffer
unmodified. I didn't have a better suggestion, but that seems pretty
sketchy to me.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20111023/72bbc347/attachment.sig>


More information about the Intel-gfx mailing list