[Intel-gfx] [PATCH] drivers: i915: Default max backlight brightness value

[Matthew Garrett]

On Fri, Oct 14, 2011 at 04:46:57PM -0700, Simon Que wrote:

Sorry, I thought I'd replied to this already. Sorry about that.

> +static u32 intel_panel_get_default_backlight_period(struct drm_device *dev)
> +{
> +	/* The default number of clock cycles in one backlight PWM period. */
> +	return 0x1000;

I'm uncomfortable with just hardcoding this, especially given that the 
comment you're removing implies that it's possible to infer the correct 
value from other GPU values. If this does vary between machines then 
simply hardcoding it now isn't really any better than the existing error 
path - it might make things better for some systems, but it has the 
potential to break hardware that expects a different value and no longer 
generates an error in that case.

-- 
Matthew Garrett | mjg59 at srcf.ucam.org