[Intel-gfx] Lock in the ironlake_panel_vdd_work()
daniel at ffwll.ch
Mon Oct 31 13:55:01 PDT 2011
On Mon, Oct 31, 2011 at 11:33:22AM -0700, Keith Packard wrote:
> On Mon, 31 Oct 2011 14:34:46 +0100, Daniel Vetter <daniel at ffwll.ch> wrote:
> > On Mon, Oct 31, 2011 at 03:01:33PM +0200, Konstantin Belousov wrote:
> > > I have a question about ironlake_panel_vdd_work(). Should it use
> > > the device struct_mutex, or need it to be the mode_config.mutex
> > > instead ?
> > Yeah. This was actually flagged in review by Chris and me, but seems to
> > have been lost in the merge. Keith?
> I thought I fixed that; it must have gotten lost in the fairly steady
> set of rebasing/reworking of that patch sequence.
Yeah, I recall having seen a fixed version somewhere ...
> commit 241dedda2785f040da45576418686490431232d2
> Author: Keith Packard <keithp at keithp.com>
> Date: Mon Oct 31 11:30:10 2011 -0700
> drm/i915: Use mode_config.mutex in ironlake_panel_vdd_work
> Use of the struct_mutex is not correct for locking in mode setting paths.
> Signed-off-by: Keith Packard <keithp at keithp.com>
Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48
More information about the Intel-gfx