[Intel-gfx] [PATCH] drm/i915: Dumb down the semaphore logic

Chris Wilson chris at chris-wilson.co.uk
Fri Sep 2 10:54:32 CEST 2011


On Thu,  1 Sep 2011 20:55:35 -0700, Ben Widawsky <ben at bwidawsk.net> wrote:
> While I think the previous code is correct, it was hard to follow and
> hard to debug. Since we already have a ring abstraction, might as well
> use it to handle the semaphore updates and compares.
> 
> I don't expect this code to make semaphores better or worse, but you
> never know...

So "dumbing it down" means using macros instead of small functions and
putting magic values into the ring structure. I'm not sure if that's an
improvement to readability at all.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list