[Intel-gfx] [PATCH] drm/i915: Dumb down the semaphore logic

Ben Widawsky ben at bwidawsk.net
Sat Sep 3 22:09:47 CEST 2011


On Fri, 02 Sep 2011 12:10:28 -0700
Eric Anholt <eric at anholt.net> wrote:

> On Thu,  1 Sep 2011 20:55:35 -0700, Ben Widawsky <ben at bwidawsk.net>
> wrote:
> > While I think the previous code is correct, it was hard to follow
> > and hard to debug. Since we already have a ring abstraction, might
> > as well use it to handle the semaphore updates and compares.
> > 
> > I don't expect this code to make semaphores better or worse, but you
> > never know...
> 
> This code is generally more legible, and I think I could review it
> compared to the specs in a few minutes instead of the awful I
> experience I had reviewing what was there before (particularly the
> awful % tricks).  Still, some review inline:

Keith, worth cleaning this one up?



More information about the Intel-gfx mailing list