[Intel-gfx] [PATCH 5/5] drm/i915: tracepoints for semaphores

Daniel Vetter daniel at ffwll.ch
Fri Sep 16 11:07:29 CEST 2011


On Fri, Sep 16, 2011 at 09:37:41AM +0100, Chris Wilson wrote:
> On Fri, 16 Sep 2011 09:58:53 +0200, Daniel Vetter <daniel at ffwll.ch> wrote:
> > We already have trace_i915_gem_request_add in i915_add_request which is
> > essentially giving out the same information (well, minus the hopefully
> > correct singal_mbox reg addresses). I think we can drop this one.
> 
> I thought that as well, but then realised that a complete set of ring
> tracepoints would be useful independent of the request/object
> tracepoints.
> 
> A couple of tracepoints on the gen6 paths is insufficients. ;-)

Well, I've quickly reviewed them and I think we're mostly covered. Many of
the tracepoints are called from generic code i915_gem.c right before/after
calling into the chipset-specific ringbuffer functions.
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48



More information about the Intel-gfx mailing list