[Intel-gfx] [PATCH 4/6] drm/i915: fix reset handling in the throttle ioctl

Damien Lespiau damien.lespiau at intel.com
Wed Dec 5 15:08:29 CET 2012


On Wed, Nov 14, 2012 at 4:14 PM, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> The throttle ioctl doesn't take the struct_mutex, so to avoid busy-looping
> with -EAGAIN while a reset is in process, check for errors first and wait
> for the handler to complete if a reset is pending by calling
> i915_gem_wait_for_error.

The code looks like it does the right thing (wait for the completion
first and then call check_wedge()), but here the commit message states
that it check for errors first and then wait for the completion?

Other than that:

Reviewed-by: Damien Lespiau <damien.lespiau at intel.com>

-- 
Damien



More information about the Intel-gfx mailing list