[Intel-gfx] [PATCH 4/4] drm/i915/dp: Don't log the DPCD if we are disconnected

Damien Lespiau damien.lespiau at gmail.com
Wed Dec 12 20:50:41 CET 2012


From: Damien Lespiau <damien.lespiau at intel.com>

It's a bit useless to print out an all null DPCD when we are
disconnected and just clutter the debug logs.

Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index fe3c22f..42058fa 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -2362,13 +2362,13 @@ intel_dp_detect(struct drm_connector *connector, bool force)
 	else
 		status = g4x_dp_detect(intel_dp);
 
+	if (status != connector_status_connected)
+		return status;
+
 	hex_dump_to_buffer(intel_dp->dpcd, sizeof(intel_dp->dpcd),
 			   32, 1, dpcd_hex_dump, sizeof(dpcd_hex_dump), false);
 	DRM_DEBUG_KMS("DPCD: %s\n", dpcd_hex_dump);
 
-	if (status != connector_status_connected)
-		return status;
-
 	intel_dp_probe_oui(intel_dp);
 
 	if (intel_dp->force_audio != HDMI_AUDIO_AUTO) {
-- 
1.7.11.7




More information about the Intel-gfx mailing list