[Intel-gfx] [PATCH 2/4] drm/i915: Always clear semaphore mboxes on seqno wrap

Chris Wilson chris at chris-wilson.co.uk
Mon Dec 17 20:15:40 CET 2012


On Mon, 17 Dec 2012 18:44:27 +0200, Mika Kuoppala <mika.kuoppala at linux.intel.com> wrote:
> We need to clear the hw semaphore values explicitly.
> Even if sync_seqnos are zero, there might still be
> invalid values in the hw semaphores when we wrap.

This changelog does not make it clear why you want this patch. This is
for enabling a future feature, right?

Anyway, after initial misgivings because I thought you were trying to
fix a bug rather than add a feature, and provided that you improve the
changelog,

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list