[Intel-gfx] [PATCH] drm/i915: fixup overlay stolen memory leak

[Chris Wilson]

On Tue, 18 Dec 2012 15:24:37 +0100, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> We need to clean up the overlay first, before taking down the
> stolen memory allocator.
> 
> This regression has been introducec in
> 
> commit 8040513870399f1cb032cb8bc805df5042fedcdf
> Author: Chris Wilson <chris at chris-wilson.co.uk>
> Date:   Thu Nov 15 11:32:29 2012 +0000
> 
>     drm/i915: Allocate overlay registers from stolen memory
> 
> Note: This is just a quick hack to shut up a warning in the module
> unload code, so that I can check again whether we don't leak any
> framebuffers.
> 
> v2: Rework the patch a bit as suggested by Chris Wilson:
> - move the overlay teardown up, into the modeset cleanup
> - move the stolen mm takedown into i915_gem_cleanup_stolen
> 
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

That organisation indeed makes more sense.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris
-- 
Chris Wilson, Intel Open Source Technology Centre