[Intel-gfx] [PATCH 3/3] drm/i915: Preallocate mm node for GTT mmap offset

Dave Airlie airlied at gmail.com
Tue Dec 18 23:10:24 CET 2012


> As the shrinker may be invoked for the allocation, and it may reap
> neighbouring objects in the offset range mm, we need to be careful in
> the order in which we allocate the node, search for free space and then
> insert the node into the mmap offset range manager.

Maybe I'm being a bit stupid here, but this seems like a pointless
micro optimisation thrown in with a
deinlining.

Surely just calling drm_gem_create_mmap_offset a few times would work fine.

Like does it really fail that often, and is the extra overhead when it
does going to matter?

Dave.



More information about the Intel-gfx mailing list