[Intel-gfx] [PATCH] drm/i915: error_buffer->ring should be signed

[Paul Menzel]

Am Donnerstag, den 16.02.2012, 11:03 +0100 schrieb Daniel Vetter:
> gcc seems to get uber-anal recently about these things.

which was introduced by the following commit.

        96154f2faba5: "drm/i915: switch ring->id to be a real id"

> Reported-by: Dan Carpenter <dan.carpenter at oracle.com>

The URL of the report is the following.

http://lists.freedesktop.org/archives/dri-devel/2012-February/019183.html

> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Acked-by: Paul Menzel <paulepanter at users.sourceforge.net>

> ---
>  drivers/gpu/drm/i915/i915_drv.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index b839728..35833fc 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -199,7 +199,7 @@ struct drm_i915_error_state {
>  		u32 tiling:2;
>  		u32 dirty:1;
>  		u32 purgeable:1;
> -		u32 ring:4;
> +		s32 ring:4;
>  		u32 cache_level:2;
>  	} *active_bo, *pinned_bo;
>  	u32 active_bo_count, pinned_bo_count;


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120216/eac6e9df/attachment.sig>