[Intel-gfx] [PATCH] drm/i915: paper over missed irq issues with force wake vodoo

Daniel Vetter daniel at ffwll.ch
Sun Jan 15 16:03:28 CET 2012


On Sun, Jan 15, 2012 at 07:35, Keith Packard <keithp at keithp.com> wrote:
> On Sat, 14 Jan 2012 13:12:07 +0100, Daniel Vetter <daniel at ffwll.ch> wrote:
>
>> I think that race is air-tight with your patch to rework the reset code
>> already. But better safe than sorry. And as I've said a good cleanup
>> anyway.
>
> Sounds good. I like clearer code, especially when it doesn't cost
> performance. I think I'd like my version in -fixes so that we don't
> change anything with -next; no reason to have two slightly different
> versions out there in case one (or the other) is broken?

Having the one-liner fix as separate patch makes backporting to 3.2
simpler. But I don't care much, so if you amend your commit to mention
the small fix hidden in the cleanup and add a note that the fix needs
to go to 3.2-stable that's fine by me, too.
-Daniel
-- 
Daniel Vetter
daniel.vetter at ffwll.ch - +41 (0) 79 364 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list