[Intel-gfx] [PATCH 1/1] drm/i915: print out which pixel format we do not support

Daniel Vetter daniel at ffwll.ch
Tue Jan 17 18:23:00 CET 2012


On Tue, Jan 17, 2012 at 03:11:11PM -0200, Eugeni Dodonov wrote:
> Otherwise, we are left with pretty bogus message saying that the pixel
> format is not supported while leaving the details to the telepatic powers.
> 
> Signed-off-by: Eugeni Dodonov <eugeni.dodonov at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index ebe71ed..5d47d0d 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -7880,7 +7880,8 @@ int intel_framebuffer_init(struct drm_device *dev,
>  	case DRM_FORMAT_VYUY:
>  		break;
>  	default:
> -		DRM_ERROR("unsupported pixel format\n");
> +		DRM_ERROR("unsupported pixel format %u\n",
> +				mode_cmd->pixel_format);

While we're bashing Jesse, this looks like a user-triggerable error. Can
we have a DRM_DEBUG_KMS instead?
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48



More information about the Intel-gfx mailing list