[Intel-gfx] [PATCH 1/2] drm/i915: argument for deferring retirement

Keith Packard keithp at keithp.com
Wed Jan 25 00:00:05 CET 2012


On Tue, 24 Jan 2012 14:42:02 -0800, Ben Widawsky <ben at bwidawsk.net> wrote:
> Sometimes it may be the case when we idle the gpu or wait on something
> we don't actually want to process the retiring list. This patch allows
> callers to choose the behavior.

<bikeshed>
!defer_retirement sounds like a double-negative to me, might be better
to have the parameter called 'do_retire' and change usage to match?
</bikeshed>

In any case, this looks easy to understand to me.

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120124/a4b8afc1/attachment.pgp>


More information about the Intel-gfx mailing list