[Intel-gfx] [PATCH 35/43] drm/i915: rewrite shmem_pread_slow to use copy_to_user

Daniel Vetter daniel at ffwll.ch
Mon Jan 30 23:37:13 CET 2012

On Wed, Dec 14, 2011 at 01:57:32PM +0100, Daniel Vetter wrote:
> Like for shmem_pwrite_slow. The only difference is that because we
> read data, we can leave the fetched cachelines in the cpu: In the case
> that the object isn't in the cpu read domain anymore, the clflush for
> the next cpu read domain invalidation will simply drop these
> cachelines.
> slow_shmem_bit17_copy is now ununsed, so kill it.
> With this patch tests/gem_mmap_gtt now actually works.
> v2: add __ to copy_to_user_swizzled as suggested by Chris Wilson.
> v3: Fixup the swizzling logic, it swizzled the wrong pages.
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38115
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
I've picked up these 3 patches to finally fix the pwrite/pread -EFAULT
bug. Assuming nothing pops up in testing this week and no one raises any
complains about the currently queued patches, I'll push out a new -next
after fosdem with the current set of patches in -next-queued.
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48

More information about the Intel-gfx mailing list