[Intel-gfx] [PATCH] drm/i915: don't forget the PCH backlight registers

Daniel Vetter daniel at ffwll.ch
Sat Jul 14 18:15:31 CEST 2012


On Sat, Jul 14, 2012 at 11:57:12AM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni at intel.com>
> 
> When we enable/disable the CPU backlight registers we can't forget to
> enable/disable the PCH backlight registers. Since we're using the CPU
> registers we should also unset the override bit.
> 
> Fixes a regression on the following commit:
>   drm/i915: properly enable the blc controller on the right pipe
> 
> The commit just deleted the code that sets the PCH registers, so it
> was relying on the values set by the BIOS. I told my BIOS to boot on
> the DVI monitor instead of the LVDS panel, so I noticed the bug.
> 
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
Ok, I've double-check bspec, and at least on ilk, snb & ivb this seems to
be a sane thing to do. Patch queued for -next, thanks.
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48



More information about the Intel-gfx mailing list