[Intel-gfx] [PATCH 1/3] drm/i915: clarify IBX dp workaround

Chris Wilson chris at chris-wilson.co.uk
Fri Jun 1 22:04:48 CEST 2012


On Fri, 1 Jun 2012 21:40:18 +0200, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Wed, May 30, 2012 at 11:28:13AM +0100, Chris Wilson wrote:
> > On Wed, 30 May 2012 12:31:56 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> > > Instead of checking for !CPT, check for IBX to make it clearer that
> > > this is a IBX-specific workaround. No functional change because we
> > > smash the PPT PCH into the HAS_PCH_CPT check and atm DP isn't enabled
> > > on the haswell LPT PCH yet.
> > > 
> > > See Bspec Vol 3, Part 3, Section 4.[3-5].1 about DP[BCD], bit 30 for
> > > details of this workaround.
> > > 
> > > Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> > Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> Queued for -next, thanks for the review. Can you also please look at the
> other two patches again whether my replies are satisfactory?

Sure, the replies were explanation enough to point out my mistake. As
always a reminder closer to the code would be useful...
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list