[Intel-gfx] [PATCH 4/5] drm/i915: clear up wedged transitions

Chris Wilson chris at chris-wilson.co.uk
Tue Nov 13 09:56:39 CET 2012


On Mon, 12 Nov 2012 23:07:52 +0100, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> While auditing the code I've noticed one place (the throttle ioctl)
> which does not yet wait for the reset handler to complete and doesn't
> properly decode the wedge state into -EAGAIN/-EIO. Fix this up by
> calling the right helpers. This might explain the oddball "my
> compositor just died in a successfull gpu reset" reports.

It is a standalone bugfix and should be split into its own patch. But I
don't think it quite has the impact you describe, since it only called
by the ddx and only sna bothers to check the error code.  And one
side-effect is that I think for especilly this case
i915_gem_check_wedge() should be setting set_need_resched() before
returning -EAGAIN.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list