[Intel-gfx] [PATCH 1/2] intel: Sync the parameter of i915_getparma with the kernel

[Daniel Vetter]

On Fri, Nov 16, 2012 at 2:52 AM, Xiang, Haihao <haihao.xiang at intel.com> wrote:
> On Thu, 2012-11-15 at 12:30 +0100, Daniel Vetter wrote:
>> On Wed, Nov 14, 2012 at 12:46:38PM +0800, Xiang, Haihao wrote:
>> > From: Zhao Yakui <yakui.zhao at intel.com>
>> >
>> > Signed-off-by: Zhao Yakui <yakui.zhao at intel.com>
>>
>> Fyi the best way is to simply run
>>
>> $ make headers_install
>>
>> in the latest kernel tree and copy the resulting userspace header from
>> usr/include/drm/i915_drm.h to libdrm. Otherwise things tend to get out of
>> sync. In the commit message you can then mention up to which kernel commit
>> you've synced.
>> -Daniel
>
>
> Thanks for your comment. But it will bring some changes to the existent
> data structures by this way, such as
>
> -struct drm_i915_gem_cacheing {
> +struct drm_i915_gem_caching {
>
> Is this what we want ?

Presuming it doesn't change any of the exposed libdrm interfaces, yes
this is what we want - the kernel and libdrm i915_drm.h file should be
in sync. In this specific case we've decided that the mispelling is
too awful to be allowed to live on ;-)
-Daniel