[Intel-gfx] [PATCH 05/10] drm/i915: make DP work on LPT-LP machines

Paulo Zanoni przanoni at gmail.com
Tue Nov 20 20:14:40 CET 2012


Hi

2012/11/20 Damien Lespiau <damien.lespiau at intel.com>:
> On Tue, Nov 20, 2012 at 5:12 PM, Paulo Zanoni <przanoni at gmail.com> wrote:
>> From: Paulo Zanoni <paulo.r.zanoni at intel.com>
>>
>> We need to enable a special bit, otherwise none of the DP functions
>> requiring the PCH will work.
>>
>> Version 2: store the PCH ID inside dev_priv, as suggested by Daniel
>> Vetter.
>>
>> Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
>
> This makes priv->pch_type and priv->pch_id somewhat redundant, but the
> fact that type is always growing with newer PCHs is used in
> intel_sdvo.c and seems a useful thing to be able to do, so:

I believe the idea is that pch_type may include more than one pch_id.
Like for example, PCH_CPT involves not only the CougarPoint PCHs, but
also the PantherPoint PCH. Also, PCH_LPT currently involves LynxPoint
and LynxPoint-LP.

>
> Reviewed-by: Damien Lespiau <damien.lespiau at intel.com>
>
> --
> Damien



-- 
Paulo Zanoni



More information about the Intel-gfx mailing list