[Intel-gfx] [PATCH 2/2] drm/i915: Warn if ring tail is not qword aligned

Daniel Vetter daniel at ffwll.ch
Mon Nov 26 16:55:27 CET 2012


On Mon, Nov 26, 2012 at 1:48 PM,  <ville.syrjala at linux.intel.com> wrote:
> +       /* tail must be qword aligned */
> +       WARN_ON(ring->tail & 7);

Minor bikeshed: Can you move the comment into the WARN argument so
that if someone forgets to correctly pad stuff, dmesg will directly
tell him wants wrong, instead of being forced to check the line
numbers? Helps ridiculously lazy people like me ... ;-)

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list