[Intel-gfx] [PATCH 3/3] drm/i915: don't rewrite the GTT on resume

Jesse Barnes jbarnes at virtuousgeek.org
Mon Oct 15 17:49:08 CEST 2012


On Mon, 15 Oct 2012 09:41:33 +0200
Daniel Vetter <daniel at ffwll.ch> wrote:

> On Sun, Oct 14, 2012 at 07:10:38PM -0700, Jesse Barnes wrote:
> > The BIOS shouldn't be touching this memory across suspend/resume, so
> > just leave it alone.  This saves us ~50ms on resume on my T420.
> 
> Is that 50ms still accurate with wc gtt ptes?

No, I haven't done timings since we switched.  If we determine that the
tlb invalidate is sufficient to fix the problems we saw earlier that
made us do the rewrite, then maybe we can just remove it in favor of a
debug option to CRC the GTT PTEs per my previous patch, and remove this
code altogether.

Jesse



More information about the Intel-gfx mailing list