[Intel-gfx] [PATCH 2/2] drm/i915/sdvo: restore i2c adapter config on intel_sdvo_init() failures

Chris Wilson chris at chris-wilson.co.uk
Tue Oct 23 11:40:20 CEST 2012


On Mon, 22 Oct 2012 16:12:18 +0300, Jani Nikula <jani.nikula at intel.com> wrote:
> SDVOB may be multiplexed with HDMIB. If it's not SDVOB, the same i2c
> adapter may be used for HDMIB, with the adjusted config (i.e. with GPIO
> bit-banging instead of gmbus). Restore i2c adapter config before error
> return from intel_sdvo_init(), letting HDMIB enjoy the joys of gmbus.

I would personally not make the assumption that set_speed has no effect.
Disabling GMBUS is a hack that we should eventually lift.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list