[Intel-gfx] [PATCH 5/9] drm/i915: split intel_dp_init into encoder and connector pieces

Lespiau, Damien damien.lespiau at intel.com
Tue Oct 30 13:07:08 CET 2012


On Fri, Oct 26, 2012 at 10:05 PM, Paulo Zanoni <przanoni at gmail.com> wrote:
> From: Paulo Zanoni <paulo.r.zanoni at intel.com>
>
> Same reason as the previous HDMI commit: the DDI code will have its
> own encoder init function but still use the DP and HDMI connectors.
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>

> +intel_dp_init(struct drm_device *dev, int output_reg, enum port port)
...
> +       intel_dig_port->hdmi.sdvox_reg = 0;

That one does not seem necessary, esp. in dp_init() and seems to have
been added. Other than that:

Reviewed-by: Damien Lespiau <damien.lespiau at intel.com>

-- 
Damien



More information about the Intel-gfx mailing list