[Intel-gfx] [PATCH 00/58] modeset-rework, the basic conversion

Daniel Vetter daniel at ffwll.ch
Thu Sep 6 08:55:40 CEST 2012


On Wed, Sep 05, 2012 at 04:23:55PM -0700, Jesse Barnes wrote:
> On Sun, 19 Aug 2012 21:12:17 +0200
> Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> 
> > Hi all,
> > 
> > Changes since last time around:
> > - The prep patches are all merged now.
> > - I've left out the actual DP fixes/cleanups, I think we should merge those in a
> >   separte step.
> > - A few bugfixes (thanks to Paulo, Jani and Chris).
> > - I've also applied a few bikesheds for naming that Paulo suggested (but I'm not
> >   sure whether I've sent those out already in a previous patchbomb).
> > 
> > Essentially this is just the core rework, which addes the new get_hw_state code,
> > refactors all the encoders to use the new functions and finally reworks the
> > modeset logic to disable/enable entire pipes, always (and with a deterministic
> > order).
> > 
> > For merging to -next, I plan to pull in everything with a real merge commit. For
> > that reason I've put up a modeset-rework-base branch onto my private fdo repo[1].
> > That way I can put a short documentation for the new modeset design into the
> > merge commit (stichted together from the previous patchbomb cover letters),
> > documenting my folly assumptions for eternity.
> > 
> > I'll also plan to put tags for the entire series in the merge commit, so if you
> > have tested this on a few machines, read through and agree with the new designs,
> > please reply with your tested-by/acked-by/reviewed-by tags.
> > 
> > Flames, comments and test reports highly welcome.
> 
> Ok I've tested on Ironlake, Cantiga, Crestline, and Pineview so far and
> things look good.  I ran testdisplay both with and without VGA
> attached (the ILK has a eDP panel), and tried S3 and S4 both with and
> without VGA both in the console and in X.
> 
> There was one issue on Pineview where the VGA seemed to get
> "forgotten", but I haven't isolated it yet.  I canceled testdisplay
> part way through and that seemed to confuse fbcon about what was there.

QA reported a similar issue where fbcon refuses to light up the display
after testdisplay completed a while back:

https://bugs.freedesktop.org/show_bug.cgi?id=42194

> I also see an issue with 1280x800 modes across all platforms, but that
> may just be the monitor, I need to test more.
> 
> I'm testing Montara (that's 855 for you youngsters) now, but it's slow
> so not all my builds have completed there yet.
> 
> Overall though:
> Tested-by: Jesse Barnes <jbarnes at virtuousgeek.org>

Cool, thanks a lot for review&testing. I'll do the merge now (need to slap
all your r-b's onto patches first).
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48



More information about the Intel-gfx mailing list