[Intel-gfx] [PATCH 1/3] drm/i915: fix up the IBX transcoder B check

Daniel Vetter daniel at ffwll.ch
Tue Sep 11 17:26:28 CEST 2012


On Tue, Sep 11, 2012 at 11:57:56AM -0300, Paulo Zanoni wrote:
> 2012/9/10 Daniel Vetter <daniel.vetter at ffwll.ch>:
> > This has been added in
> >
> > commit de9a35abb3b343a25065449234e47a76c4f3454a
> > Author: Daniel Vetter <daniel.vetter at ffwll.ch>
> > Date:   Tue Jun 5 11:03:40 2012 +0200
> >
> >     drm/i915: assert that the IBX port transcoder select w/a is implemented
> >
> > Unfortunately I've failed to notice that these checks are not just
> > called for the port that is about to be disabled, but for all (which
> > makes sense for an assert ...), and the WARN missfired when disabling
> > another pipe than the one with the dp port.
> >
> > Hence also check whether the port is actually disabled.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=54688
> > Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> 
> Looks fine:
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
Picked up for -fixes, thanks for the review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list