[Intel-gfx] [PATCH v3 01/16] drm/i915: return context from i915_switch_context()

Ben Widawsky ben at bwidawsk.net
Sat Apr 20 20:10:06 CEST 2013


On Thu, Apr 04, 2013 at 06:32:33PM +0300, Mika Kuoppala wrote:
> In preparation for the next commit, return context that
> was switched to from i915_switch_context().
> 
> v2: context in return value instead of param. (Ben Widawsky)
> 
> Signed-off-by: Mika Kuoppala <mika.kuoppala at intel.com>

I don't see this used in the next commit. While true that I initially
wrote the patch this way, I think having functions return more than just
an int is best avoided whenever possible.

Furthermore, I am immediately going to change the ring->last_context_obj
to ring->last_context, which should nullify the need to return the last
context anyway. I already have, and can submit that patch if needed.

[snip]
-- 
Ben Widawsky, Intel Open Source Technology Center



More information about the Intel-gfx mailing list