[Intel-gfx] [PATCH v2 12/17] drm/i915: Store the watermark latency values in dev_priv

Daniel Vetter daniel at ffwll.ch
Mon Aug 5 18:25:54 CEST 2013


On Thu, Aug 01, 2013 at 03:23:56PM +0100, Chris Wilson wrote:
> On Thu, Aug 01, 2013 at 04:18:50PM +0300, ville.syrjala at linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > Rather than having to read the latency values out every time, just
> > store them in dev_priv.
> > 
> > On ILK and IVB there is a difference between some of the latency
> > values for different planes, so store the latency values for each
> > plane type separately, and apply the necesary fixups during init.
> > 
> > v2: Fix some checkpatch complaints
> 
> As you are now storing these, it would also be useful to add a debugfs
> file to dump them out for sanity checking. I leave the request to adjust
> them via debugfs to somebody else ;-)

I guess since this is ramping up to be the furture plane_config we might
just need a bit of plane config dump support. Of course we need to be
careful to not redump on every nuclear pageflip, but only if something
interesting changes ...

Or did you just think of the underlying latency values that steer the wm
comuptation?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list