[Intel-gfx] [PATCH 1/5] drm/i915: WARN_ON failed map_and_fenceable

Chris Wilson chris at chris-wilson.co.uk
Sat Aug 10 10:43:48 CEST 2013


On Fri, Aug 09, 2013 at 10:12:12PM -0700, Ben Widawsky wrote:
> I just noticed in our code we don't really check the assertion, and
> given some of the code I am changing in this area, I feel a WARN is very
> nice to have.
> 
> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>

This is BUG() class. A WARN by itself here isn't going to prevent
calamity, so cleanup and let userspace die gracefully. The alternative
is random hw borkage (hopefully triggering an OOPS before it gets too
far).
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list