[Intel-gfx] [PATCH] drm/i915: fix lvds/dp panel fitter setting

Daniel Vetter daniel at ffwll.ch
Wed Aug 28 18:48:51 CEST 2013


On Wed, Aug 28, 2013 at 06:27:16PM +0300, Mika Kuoppala wrote:
> Imre Deak <imre.deak at intel.com> writes:
> 
> > If need to enable the panel fitter, the crtc timings have to be
> > programmed according to the panel's native (fixed) mode. This isn't the
> > case atm, since after the encoder changes adjusted_mode to fixed
> > mode the crtc_* timing fields of adjusted_mode will stay at their original
> > non-native values that the user passed in. This results in a corrupted
> > output.
> >
> > One exception is when we have a second pass of computing encoder configs
> > due to bandwidth limitation, since then we'll set adjusted_mode.crtc_*
> > fields to the fixed mode values set in the first pass; so in this case
> > things will work out.
> >
> > Fix this by updating the adjusted_mode.crtc_* fields when we set the
> > fixed panel mode.
> >
> > Signed-off-by: Imre Deak <imre.deak at intel.com>
> 
> Daniel, the commit that regressed seem to be
> 135c81b8c3c9a70d7b55758c9c2a247a4abb7b64 instead of
> 21d8a4756af5fdf4a42e79a77cf3b6f52678d443.
> 
> Reviewed-by: Mika Kuoppala <mika.kuoppala at intel.com>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list