[Intel-gfx] [PATCH] drm/i915: Handle untiled planes when computing their offsets

Daniel Vetter daniel at ffwll.ch
Thu Feb 21 21:52:33 CET 2013


On Thu, Feb 21, 2013 at 10:17:37PM +0200, Ville Syrjälä wrote:
> On Thu, Feb 21, 2013 at 08:04:31PM +0000, Chris Wilson wrote:
> > We trim the fb to fit the CRTC by computing the offset of that CRTC to
> > its nearest tile_row origin. This allows us to use framebuffers that are
> > larger than the CRTC limits without additional work.
> > 
> > However, we failed to compute the offset for a linear framebuffer
> > correctly as we treated its x-advance in whole tiles (instead of the
> > linear increment expected), leaving the CRTC misaligned with its
> > contents.
> > 
> > Fixes regression from commit c2c75131244507c93f812862fdbd4f3a37139401
> > Author: Daniel Vetter <daniel.vetter at ffwll.ch>
> > Date:   Thu Jul 5 12:17:30 2012 +0200
> > 
> >     drm/i915: adjust framebuffer base address on gen4+
> > 
> > v2: Adjust relative x-coordinate after linear alignment (vsyrjala)
> > v3: Repaint with pokadots (vsyrjala)
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=61152
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> > Cc: stable at vger.kernel.org
> 
> Looking good.
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
Picked up for -fixes, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list