[Intel-gfx] [PATCH 11/13] drm/i915: add batch object and context to i915_add_request()

Chris Wilson chris at chris-wilson.co.uk
Tue Feb 26 15:22:34 CET 2013


On Tue, Feb 26, 2013 at 01:05:14PM +0200, Mika Kuoppala wrote:
> In order to track down a batch buffer and context which
> caused the ring to hang, store reference to bo and context
> into the request struct. Request can also cause gpu to hang
> after the batch in the flush section in the ring. To detect this
> add start of the flush portion offset into the request.

The call to i915_add_request() is becoming grotesque. We have two classes
of callers, execbuffer which sets everything and everyone else who set
nothing. So please provide a macro to curry all the extra unused
parameters and minimise the number of places we need to update
everytime the interface changes.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list