[Intel-gfx] [PATCH v.2 00/12] Detect and deal with Interrupt 'Storms' from noisy Hotplug Lines.

Chris Wilson chris at chris-wilson.co.uk
Thu Feb 28 01:46:03 CET 2013


On Mon, Feb 25, 2013 at 12:06:47PM -0500, Egbert Eich wrote:
> I've reworked my 'hotplug interrupt storm detection'-patches and 
> included most of Daniel's suggestions.
> I've looked into adding EDID caching but since this requires some
> larger scale changes and some changes outside of the Intel driver
> it seemed to be a good idea to propose those changes at a later time.
> 
> Egbert Eich (12):
>   DRM/i915: Remove valleyview_hpd_irq_setup.
>   DRM/I915: Add enum hpd_pin to intel_encoder.
>   DRM/i915: Convert HPD interrupts to make use of HPD pin assignment in
>     encoders.
>   DRM/i915: Remove i965_hpd_irq_setup.
>   DRM/i915: Get rid if the 'hotplug_supported_mask' in struct
>     drm_i915_private.
>   DRM/i915: Add HPD IRQ storm detection.
>   DRM/i915: (re)init HPD interrupt storm statistics.
>   DRM/i915: Treat hpd_irq_setup() for ironake and older generations the
>     same way.
>   DRM/i915: Disable HPD interrupt on pin when irq storm is detected.
>   DRM/i915: Add Reenable Timer to turn Hotplug Detection back on.
>   DRM/i915: Add bit field to record which pins have received HPD
>     events.
>   DRM/i915: Only reprobe display on encoder which has received an HPD
>     event.

I'm happy with this series. It seems to do everything that we need to
enable/disable hpd, and tidies up hotplug detection in the process.

Acked-by: Chris Wilson <chris at chris-wilson.co.uk>

Didn't spot anything wrong in the first pass, but I'd like to let the
details soak in a bit before r-b.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list