[Intel-gfx] [PATCH 2/2] drm/i915: Adding a warning to FBC description

[Daniel Vetter]

On Thu, Jan 31, 2013 at 4:13 AM, Ben Widawsky <ben at bwidawsk.net> wrote:
>> Yeah, I agree it's *our* general assumption that these may have bad
>> side-effects. People just see the random forum posts recommending this
>> and that module param, and stick them in... Hmm, which means they won't
>> read that warning anyway. DRM_INFO("don't report a bug about this") when
>> enabling a feature that's disabled by default on a platform?
>>
>> Jani.
>
> Now that's the kind of pessimism I like to hear! OTOH, the current
> message: "Enable frame buffer compression for power savings" wouldn't
> indicate any reason to not use it. And yes, I know, what git blame says.
> I was on a personal crusade to fix FBC on ILK when I wrote that.
>
> I like DRM_INFO as well, but I don't really see a reason not to change
> the modinfo (DRM_INFO requires loading the wrong setting first).

Ok, count me convinced to merge such patches. Though I personally
don't care and don't mind checking bug reports for these, it looks
like I'm in the minority opinion.

I'd like though that such a solution not just takes care of fbc, but
also some of the other dangerous options (which are most): rc6 can
cause hangs, advanced power features can lead to flashing displays,
...

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch