[Intel-gfx] [PATCH] drm/i915: correctly restore fences with objects attached

Chris Wilson chris at chris-wilson.co.uk
Wed Jul 17 17:47:32 CEST 2013


On Wed, Jul 17, 2013 at 08:34:48AM -0700, Jesse Barnes wrote:
> On Wed, 17 Jul 2013 14:51:28 +0200
> Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> 
> > +		if (reg->obj) {
> > +			i915_gem_object_update_fence(reg->obj, reg,
> > +						     reg->obj->tiling_mode);
> > +		} else {
> > +			i915_gem_write_fence(dev, i, NULL);
> > +		}
> 
> Why do we look at reg->obj here?  Can it be NULL?  Or would
> reg->obj->tiling_mode != I915_TILING_NONE do the same thing?

Yes. This is the array of fence registers, irrespective of whether an
object is using one.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list