[Intel-gfx] Maintainer-review fluff (was: Re: [PATCH 01/12] drm/i915: plumb VM into object operations)

Jesse Barnes jbarnes at virtuousgeek.org
Fri Jul 26 19:12:43 CEST 2013


On Fri, 26 Jul 2013 18:08:48 +0100
Chris Wilson <chris at chris-wilson.co.uk> wrote:

> On Fri, Jul 26, 2013 at 09:59:42AM -0700, Jesse Barnes wrote:
> >   4) review comments should be concrete and actionable, and ideally not
> >      leave the author hanging with hints about problems the reviewer
> >      has spotted, leaving the author looking for easter eggs
> 
> Where am I going to find my fun, if I am not allowed to tell you that
> you missed a zero in a thousand line patch but not tell you where?
> Spoilsport :-p

You'll just need to take up golf or something. :)

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list