[Intel-gfx] [PATCH 3/8] drm/i915: allow package C8+ states on Haswell (disabled)

Chris Wilson chris at chris-wilson.co.uk
Tue Jul 30 01:11:57 CEST 2013


On Mon, Jul 29, 2013 at 05:48:22PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni at intel.com>
> 
> This patch allows PC8+ states on Haswell. These states can only be
> reached when all the display outputs are disabled, and they allow some
> more power savings.

This explanation needs to be kept in the code somewhere, either as a
small theory of operation before the pc8 logic (if you want to expand it
some more), but this sentence can quite aptly go inside struct
drm_i915_private {
   /* When all display outputs are disabled, and the display power well
    * turned off, we can enable pc8 for further power savings.
    */
   struct i915_package_c8 package_c8;
 };
We just need some statement of what we are tracking and why.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list