[Intel-gfx] [PATCH] drm/i915: enable IPS for bpp <= 24

[Paulo Zanoni]

2013/7/25 Jesse Barnes <jbarnes at virtuousgeek.org>:
> Art confirms that this should work fine.  Since most panels are 18bpp
> with dithering from 24bpp, the existing code wouldn't be enabled in most
> cases.
>

I previously said I tested this in the past and it didn't work. So
today I tested it again and I discovered that the problem is that if I
configure X to use DefaultDepth 16, my eDP monitor won't work *at
all*, even with IPS disabled. Everything else seems to work.

Sorry for the wrong information.

Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>

> Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> ---
>  drivers/gpu/drm/i915/intel_display.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 12ea1a9..7cf475b 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -4091,7 +4091,7 @@ static void hsw_compute_ips_config(struct intel_crtc *crtc,
>  {
>         pipe_config->ips_enabled = i915_enable_ips &&
>                                    hsw_crtc_supports_ips(crtc) &&
> -                                  pipe_config->pipe_bpp == 24;
> +                                  pipe_config->pipe_bpp <= 24;
>  }
>
>  static int intel_crtc_compute_config(struct intel_crtc *crtc,
> --
> 1.7.9.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Paulo Zanoni