[Intel-gfx] [PATCH] drm/i915: Reorder ring reinitialisation round reset

Ben Widawsky ben at bwidawsk.net
Wed Jun 12 23:15:48 CEST 2013


On Mon, Jun 10, 2013 at 01:54:50PM +0100, Chris Wilson wrote:
> In particular, we were reseting our GEM tracking before even attempting
> (and failing) to reset the chip. Do it with the other bookkeeping after
> successfully reseting. Note that we can simplify the reset to always do
> the GPU reinitialisation as for UMS it will simply be redundant in the
> case where X was switched away. And that we can safely re-establish all
> the features that were setup during initialisation - any that were not
> enabled for UMS/DRI1 will not be restored and should still not be enabled.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
>

FWIW: I have some patches in my PPGTT series which I think accomplish the same
thing with a nicer end result.

See the, "use hw_init" patch. I've fine tuned things a bit since then
too, iirc.
[snip]
-- 
Ben Widawsky, Intel Open Source Technology Center



More information about the Intel-gfx mailing list