[Intel-gfx] [PATCH 07/24] drm/i915: fold the no-irq check into intel_hpd_irq_handler

Daniel Vetter daniel at ffwll.ch
Thu Jun 27 12:39:52 CEST 2013


On Wed, Jun 26, 2013 at 07:35:18PM -0300, Paulo Zanoni wrote:
> 2013/6/12 Egbert Eich <eich at suse.com>:
> > Daniel Vetter writes:
> >  > The usual pattern for our sub-function irq_handlers is that they check
> >  > for the no-irq case themselves. This results in more streamlined code
> >  > in the upper irq handlers.
> >  >
> >  > Cc: Egbert Eich <eich at suse.de>
> >  > Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> >  > ---
> >  >  drivers/gpu/drm/i915/i915_irq.c | 33 +++++++++++++++++----------------
> >  >  1 file changed, 17 insertions(+), 16 deletions(-)
> >  >
> >
> > [reviewed code deleted]
> >
> > Reviewed-by: Egbert Eich <eich at suse.de>
> 
> Patches 4, 5, 6 and 7 (all reviewed by Egbert) are also Reviewed-by:
> Paulo Zanoni <paulo.r.zanoni at intel.com>
> 
> But I do have to notice they don't apply anymore due to
> s/hpd_status_i965/hpd_status_i915/

Yeah, I'll fix up the patches and resend the first 7 anew.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list