[Intel-gfx] [PATCH 6/6] drm/i915: Use BUG() in a case of a programming error

[Paulo Zanoni]

Hi

2013/3/7 Damien Lespiau <damien.lespiau at intel.com>:
> The port number should always be correctly set. Do the same thing as the
> switch above and use BUG() to signal that branch is not supposed to be
> taken.
>
> Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>

Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>

> ---
>  drivers/gpu/drm/i915/intel_dp.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 3921d87..a998c3c 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -2837,8 +2837,7 @@ intel_dp_init_connector(struct intel_digital_port *intel_dig_port,
>                 name = "DPDDC-D";
>                 break;
>         default:
> -               WARN(1, "Invalid port %c\n", port_name(port));
> -               break;
> +               BUG();
>         }
>
>         if (is_edp(intel_dp))
> --
> 1.7.7.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Paulo Zanoni