[Intel-gfx] [PATCH] drm/i915/ddi: set sink to power down mode on dp disable

[Daniel Vetter]

On Mon, Nov 18, 2013 at 02:45:47PM -0200, Paulo Zanoni wrote:
> 2013/11/15 Jani Nikula <jani.nikula at intel.com>:
> > Similar to
> > commit fdbc3b1f639bb2cbfb32c612b2699e0ba373317d
> > Author: Jani Nikula <jani.nikula at intel.com>
> > Date:   Tue Nov 12 17:10:13 2013 +0200
> >
> >     drm/i915/dp: set sink to power down mode on dp disable
> >
> > but for DDI, where we've never done this.
> >
> > Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> 
> Makes sense, but I wonder if the correct place is this or
> intel_disable_ddi(), right after the call to
> ironlake_edp_backlight_off(). The current place is still better than
> nowhere, so: Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
> 
> >
> > ---
> >
> > UNTESTED!
> 
> I'll leave your patch applied on my tree for now. If anything explodes
> and I survive, I'll tell you :)

Picked up for -fixes, thanks for the patch.
-Daniel
> 
> 
> > ---
> >  drivers/gpu/drm/i915/intel_ddi.c |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> > index 1591576..6a63a09 100644
> > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > @@ -1158,9 +1158,10 @@ static void intel_ddi_post_disable(struct intel_encoder *intel_encoder)
> >         if (wait)
> >                 intel_wait_ddi_buf_idle(dev_priv, port);
> >
> > -       if (type == INTEL_OUTPUT_EDP) {
> > +       if (type == INTEL_OUTPUT_DISPLAYPORT || type == INTEL_OUTPUT_EDP) {
> >                 struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> >                 ironlake_edp_panel_vdd_on(intel_dp);
> > +               intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
> >                 ironlake_edp_panel_off(intel_dp);
> >         }
> >
> > --
> > 1.7.9.5
> >
> 
> 
> 
> -- 
> Paulo Zanoni
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch